lkml.org 
[lkml]   [2009]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] mtd: mtdoops: mtdoops works with kexec correctly
    Date
    > On Mon, 21 Dec 2009 19:20:35 +0900 (JST)
    > KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
    >
    > > commit 2e386e4ba(mtdoops: refactor as a kmsg_dumper) is very good patch.
    > > but unfortunately it doesn't works with kexec and few embedded user need
    > > to use kexec. there is no reason to don't implement it. it isn't so
    > > hard.
    > >
    > > FAQ
    > > ---
    > > Q. Why KMSG_DUMP_OOPS is insufficient?
    > > A. Because crash_kexec() is called before KMSG_DUMP_OOPS if
    > > panic_on_oops==1.
    > >
    > > Q. Why do you move KMSG_DUMP_PANIC call place?
    > > A. Otherwise kmsg_dump() is called twice if kexec enabled.
    > > it's annoy.
    >
    > I think it would be better to describe these comments in text instead
    > of as FAQs. Because of the --- it's also removed from the git log.
    > Maybe something like
    >
    > kmsg_dump: Dump on crash_kexec as well
    >
    > crash_kexec gets called before kmsg_dump(KMSG_DUMP_OOPS) if
    > panic_on_oops is set, so the kernel log buffer is not stored
    > for this case.
    >
    > This patch adds a KMSG_DUMP_KEXEC dump type which gets called
    > when crash_kexec() is invoked. To avoid getting double dumps,
    > the old KMSG_DUMP_PANIC is moved below crash_kexec(). The
    > mtdoops driver is modified to handle KMSG_DUMP_KEXEC in the
    > same way as a panic.
    >
    >
    > Other than that, it looks fine to me. I've done basic testing against
    > 2.6.33-rc1, but unfortunately without kexec support.
    >
    > Acked-by: Simon Kagstrom <simon.kagstrom@netinsight.net>

    Thanks. Your description is obviously better.





    \
     
     \ /
      Last update: 2009-12-22 01:05    [W:0.053 / U:6.128 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site