lkml.org 
[lkml]   [2009]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [this_cpu_xx V8 09/16] Allow arch to provide inc/dec functionality for each size separately
    On 12/19/2009 07:26 AM, Christoph Lameter wrote:
    > Current this_cpu ops only allow an arch to specify add RMW operations or inc
    > and dec for all sizes. Some arches can do more efficient inc and dec
    > operations. Allow size specific override of fallback functions like with
    > the other operations.

    Wouldn't it be better to use __builtin_constant_p() and switching in
    arch add/dec macros? It just seems a bit extreme to define all those
    different variants from generic header. I'm quite unsure whether
    providing overrides for all the different size variants from generic
    header is necessary at all. If an arch is gonna override the
    operation, it's probably best to just let it override the whole thing.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2009-12-21 08:25    [W:5.117 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site