Messages in this thread | | | Date | Sun, 20 Dec 2009 23:14:05 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] sched: Fix hotplug |
| |
On Sun, Dec 20 2009, Peter Zijlstra wrote: > The hot-unplug kstopmachine usage does a wakeup after deactivating the > cpu, hence we cannot use cpu_active() here but must rely on the good > olde online.
Yep, this works for me!
Tested-by: Jens Axboe <jens.axboe@oracle.com>
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> > --- > kernel/sched.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/sched.c b/kernel/sched.c > index 720df10..0ac4fa5 100644 > --- a/kernel/sched.c > +++ b/kernel/sched.c > @@ -2348,7 +2348,7 @@ int select_task_rq(struct task_struct *p, int sd_flags, int wake_flags) > * not worry about this generic constraint ] > */ > if (unlikely(!cpumask_test_cpu(cpu, &p->cpus_allowed) || > - !cpu_active(cpu))) > + !cpu_online(cpu))) > cpu = select_fallback_rq(task_cpu(p), p); > > return cpu; > >
-- Jens Axboe
| |