lkml.org 
[lkml]   [2009]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:sched/urgent] sched: Restore printk sanity

* Joe Perches <joe@perches.com> wrote:

> On Sun, 2009-12-20 at 18:06 +0000, tip-bot for Peter Zijlstra wrote:
> > diff --git a/kernel/sched.c b/kernel/sched.c
> > index 720df10..7ffde2a 100644
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -7828,44 +7828,48 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
> > printk(KERN_DEBUG "%*s domain %d: ", level, "", level);
> >
> > if (!(sd->flags & SD_LOAD_BALANCE)) {
> > - pr_cont("does not load-balance\n");
> > + printk("does not load-balance\n");
> > if (sd->parent)
> > - pr_err("ERROR: !SD_LOAD_BALANCE domain has parent\n");
> > + printk(KERN_ERR "ERROR: !SD_LOAD_BALANCE domain"
> > + " has parent");
>
> Missing a trailing \n.

It's also needlessly broken mid-string. Checkpatch should warn about printk
lines that end with a '"', those are almost always a sign of some ill-advised
break-the-string artifact.

Ingo


\
 
 \ /
  Last update: 2009-12-20 20:19    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site