lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH][stable] b44 WOL setup: one-bit-off stack corruption kernel panic fix
    From
    From: Stanislav Brabec <sbrabec@suse.cz>
    Date: Wed, 02 Dec 2009 15:35:20 +0100

    > Stanislav Brabec wrote:
    >> About 50% of shutdowns of b44 Ethernet adapter ends by kernel panic with
    >> kernels compiled with stack-protector.
    >>
    >> Checking b44_magic_pattern() return values, one call of
    >> b44_magic_pattern() returns 127. It means, that set_bit(128, pmask) was
    >> called on line 1509. It means that bit 0 of 17th byte of pmask was
    >> overwritten. But pmask has only 16 bytes. Stack corruption happens.
    >>
    >> It seems that set_bit() on line 1509 always writes one bit off.
    >>
    >> The fix does not only solve the stack corruption, but also makes Wake On
    >> LAN working on my onboard B44 on Asus A7V-333X mainboard.
    >>
    >> It seems that this problem affects all kernel versions since commit
    >> 725ad800 on 2006-06-20.
    >
    > stable@kernel.org may be interested as well. Adding Cc:.

    netdev@vger.kernel.org is even more interested. Please post all
    networking patches CC:'d there so they get properly logged
    and tracked in patchwork.

    Thank you.


    \
     
     \ /
      Last update: 2009-12-03 00:45    [W:0.021 / U:3.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site