[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [PATCH] mfd/mc13783: near complete rewrite
    Hi Samuel,

    > > If it looks OK for you, can you please squash the patch below into the
    > > original commit?
    > That's fine with me, I'll do it.
    In the hope not to annoy you, below is another modification that greatly
    improves the touch function. Feel free to to squash into the original
    commit again.

    Best regards and thanks

    From: Uwe Kleine-König <>

    mfd/mc13783: don't set ADREFMODE for touch conversions

    Setting ADREFMODE is utter nonsense, but that's hard to read out of the
    spec. Strange enough it's possible to read x and y values even when
    it's set. When unset you can get values not only for the axes, but also
    for contact resistance which allows the touch driver to report pressure

    Signed-off-by: Uwe Kleine-König <>
    drivers/mfd/mc13783-core.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/mfd/mc13783-core.c b/drivers/mfd/mc13783-core.c
    index dc1add0..a1ade23 100644
    --- a/drivers/mfd/mc13783-core.c
    +++ b/drivers/mfd/mc13783-core.c
    @@ -462,8 +462,8 @@ int mc13783_adc_do_conversion(struct mc13783 *mc13783, unsigned int mode,

    switch (mode) {
    case MC13783_ADC_MODE_TS:
    - adc0 |= MC13783_ADC0_ADREFEN | MC13783_ADC0_ADREFMODE
    - | MC13783_ADC0_TSMOD0 | MC13783_ADC0_TSMOD1;
    + adc0 |= MC13783_ADC0_ADREFEN | MC13783_ADC0_TSMOD0 |
    + MC13783_ADC0_TSMOD1;
    adc1 |= 4 << MC13783_ADC1_CHAN1_SHIFT;

    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | |
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2009-12-02 19:57    [W:0.023 / U:5.448 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site