lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH][stable] b44 WOL setup: one-bit-off stack corruption kernel panic fix
    From
    Date
    Stanislav Brabec wrote:
    > About 50% of shutdowns of b44 Ethernet adapter ends by kernel panic with
    > kernels compiled with stack-protector.
    >
    > Checking b44_magic_pattern() return values, one call of
    > b44_magic_pattern() returns 127. It means, that set_bit(128, pmask) was
    > called on line 1509. It means that bit 0 of 17th byte of pmask was
    > overwritten. But pmask has only 16 bytes. Stack corruption happens.
    >
    > It seems that set_bit() on line 1509 always writes one bit off.
    >
    > The fix does not only solve the stack corruption, but also makes Wake On
    > LAN working on my onboard B44 on Asus A7V-333X mainboard.
    >
    > It seems that this problem affects all kernel versions since commit
    > 725ad800 on 2006-06-20.

    stable@kernel.org may be interested as well. Adding Cc:.

    Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
    Cc: stable@kernel.org


    diff --git a/drivers/net/b44.c b/drivers/net/b44.c
    index 2a91323..4869adb 100644
    --- a/drivers/net/b44.c
    +++ b/drivers/net/b44.c
    @@ -1505,8 +1505,7 @@ static int b44_magic_pattern(u8 *macaddr, u8 *ppattern, u8 *pmask, int offset)
    for (k = 0; k< ethaddr_bytes; k++) {
    ppattern[offset + magicsync +
    (j * ETH_ALEN) + k] = macaddr[k];
    - len++;
    - set_bit(len, (unsigned long *) pmask);
    + set_bit(len++, (unsigned long *) pmask);
    }
    }
    return len - 1;


    --
    Best Regards / S pozdravem,

    Stanislav Brabec
    software developer
    ---------------------------------------------------------------------
    SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
    Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747
    190 00 Praha 9 fax: +420 284 028 951
    Czech Republic http://www.suse.cz/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-02 15:37    [W:0.025 / U:30.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site