lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 01/21] blkio: Set must_dispatch only if we decided to not dispatch the request
    Date
    Vivek Goyal <vgoyal@redhat.com> writes:

    > o must_dispatch flag should be set only if we decided not to run the quue
    > dispatch the request.
    >
    > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
    > ---
    > block/cfq-iosched.c | 6 +++---
    > 1 files changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
    > index a5de31f..9adfa48 100644
    > --- a/block/cfq-iosched.c
    > +++ b/block/cfq-iosched.c
    > @@ -2494,9 +2494,9 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
    > if (blk_rq_bytes(rq) > PAGE_CACHE_SIZE ||
    > cfqd->busy_queues > 1) {
    > del_timer(&cfqd->idle_slice_timer);
    > - __blk_run_queue(cfqd->queue);
    > - }
    > - cfq_mark_cfqq_must_dispatch(cfqq);
    > + __blk_run_queue(cfqd->queue);
    > + } else
    > + cfq_mark_cfqq_must_dispatch(cfqq);
    > }
    > } else if (cfq_should_preempt(cfqd, cfqq, rq)) {
    > /*

    This makes sense, but could be submitted as a bugfix on its own.

    Reviewed-by: Jeff Moyer <jmoyer@redhat.com>


    \
     
     \ /
      Last update: 2009-12-02 15:11    [W:0.027 / U:178.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site