| Date | Wed, 2 Dec 2009 14:15:30 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 12/24] HWPOISON: make it possible to unpoison pages |
| |
> Note that it may leak pages silently - those who have been removed from > LRU cache, but not isolated from page cache/swap cache at hwpoison time.
It would be better if we could detect that somehow and at least warn.
> } > > +static int hwpoison_forget(void *data, u64 val) > +{ > + if (!capable(CAP_SYS_ADMIN)) > + return -EPERM; > + > + return forget_memory_failure(val); > +} > + > DEFINE_SIMPLE_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n"); > +DEFINE_SIMPLE_ATTRIBUTE(unpoison_fops, NULL, hwpoison_forget, "%lli\n");
I'll rename it to unpoison, not forget. I think that's a more clear name.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
|