Messages in this thread | | | Subject | Re: [PATCH 3/7] sched: refactor try_to_wake_up() | From | Peter Zijlstra <> | Date | Wed, 02 Dec 2009 12:01:19 +0100 |
| |
On Wed, 2009-12-02 at 19:14 +0900, Tejun Heo wrote: > On 12/02/2009 07:10 PM, Mike Galbraith wrote: > >>> I think it would _look_ better with the thing just > >>> duplicated/stripped down and called what it is, > >>> sched_notifier_wakeup() or such. > >> > >> Sorry, I'm not following. Can you elaborate a bit? > > > > I mean copying ttwu, stripping out locking etc, and renaming the result > > would look better. No functional difference though, and binary growth > > would be left in the wake of such a duplication. > > Ah... okay. Well, that was the first approach (with some missing > parts). Peter wasn't particularly happy with code duplication and > suggested refactoring ttwu and reuse common parts.
Right, esp since it missed some parts.
I haven't yet had time to look at this patch, but yeah, sharing code seems like a good idea since its tricky and fragile code.
| |