lkml.org 
[lkml]   [2009]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: reboot_fixup_32.c add missing pci_dev_put

* Xiaotian Feng <dfeng@redhat.com> wrote:

> pci_get_device increments reference count to the found pci device,
> that should be decremented using pci_dev_put.

> +++ b/arch/x86/kernel/reboot_fixups_32.c
> @@ -80,6 +80,7 @@ void mach_reboot_fixups(void)
> continue;
>
> cur->reboot_fixup(dev);
> + pci_dev_put(dev);

Does this matter in practice? We are about to reboot. (but if it's
cleaner to do it like this or if there's some real bug fixed by this
then please spell it out in the changelog.)

Ingo


\
 
 \ /
  Last update: 2009-12-02 11:13    [from the cache]
©2003-2011 Jasper Spaans