lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: e100 REGRESSION in 2.6.32 (PATCH v2)
From
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Date: Thu, 17 Dec 2009 09:21:49 -0800 (Pacific Standard Time)

>
> On Thu, 17 Dec 2009, Roger Oksanen wrote:
>> e100: Fix broken cbs accounting due to missing memset.
>>
>> Alan Stern noticed that e100 caused slab corruption.
>> commit 98468efddb101f8a29af974101c17ba513b07be1 changed
>> the allocation of cbs to use dma pools that don't return zeroed memory,
>> especially the cb->status field used to track which cb to clean, causing
>> (the visible) double freeing of skbs and a wrong free cbs count.
>>
>> Now the cbs are explicitly zeroed at allocation time.
>>
>> Reported-by: Alan Stern <stern@rowland.harvard.edu>
>> Tested-by: Alan Stern <stern@rowland.harvard.edu>
>> Signed-off-by: Roger Oksanen <roger.oksanen@cs.helsinki.fi>
>
> Change looks reasonable, ACK.

Applied, thanks everyone. I'll try to requeue the e100 stuff
together into -stable again now that this is resolved.

> should we also consider a followon patch to zero memory allocated with
> pci_pools? Seems useful.

Nah, it's more fun debugging subtle bugs like this one.
:-)


\
 
 \ /
  Last update: 2009-12-19 05:21    [W:0.081 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site