lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Drop 80-character limit in checkpatch.pl
Date
On Friday 18 December 2009 03:28:12 pm Krzysztof Halasa wrote:
> Valdis.Kletnieks@vt.edu writes:
>
> > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
> > continuation line, it's probably in its rights to whinge.
>
> Yes, but don't make it a hard error, only a suggestion that something is
> probably really wrong.
>
> > fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided)
> >
> > leaf_paste_entries(&bi,
> > n +
> > item_pos
> > -
> > ret_val,
> > l_pos_in_item,
> > 1,
> > (struct
> > reiserfs_de_head
> > *)
> > body,
> > body
> > +
> > DEH_SIZE,
> > tb->
> > insert_size
> > [0]
> > );
> >
> > Yes, that used to be 24 more columns to the right. Gaak.
>
> Precisely. It's a clear show of the damage hard rules like that do.

It is not a hard rule and the above damage was done in 2005 when some
random developer (Linus Torvalds? Is this even a real name? ;-) decided
to mindlessly pass do_balan.c file through Lindent script and later
didn't finish the task of cleaning the code properly (see commit bd4c625
for details).

We didn't even have checkpatch.pl back then (it was added in 2007).

> I can't even tell how the code should be fixed and if the simple merging
> would do, since I can't really imagine how it would look like :-)

The old code [ no tabs removed ]:

- leaf_paste_entries (bi.bi_bh, n + item_pos - ret_val, l_pos_in_item, 1,
- (struct reiserfs_de_head *)body,
- body + DEH_SIZE, tb->insert_size[0]
- );

--
Bartlomiej Zolnierkiewicz


\
 
 \ /
  Last update: 2009-12-18 16:15    [from the cache]
©2003-2011 Jasper Spaans