[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] scripts/ Change long line warning to 105 chars
    Joe Perches <> writes:

    > I think this is a good test to add to checkpatch.
    > Add 105 character long line WARN test

    Not sure if that's long enough (maybe it is).
    132 looks like the next "natural" number.
    The problematic case like printk(KERN_DEBUG "%s:%s:%s", var ? "yes" :
    "no" and so on. If we split the code like that then better use 132 than
    105 - even with 132 chars we may need to split, remember it's the printk
    output which has to fit in 80 chars, or maybe usually has.

    The main problem is checkpatch can't estimate "complexity". Fortunately
    the reviewers can.

    > Add 80 character long line STRICT test

    Not sure what do you mean.

    > Add 6+ leading indent tabs test, consider restructuring

    This makes perfect sense, at least until shown otherwise (though being
    a warning instead of an error means it's ok to trigger in perfectly
    valid code).
    Krzysztof Halasa

     \ /
      Last update: 2009-12-18 15:39    [W:0.018 / U:70.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site