lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[064/151] mac80211: Fix bug in computing crc over dynamic IEs in beacon
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Vasanthakumar Thiagarajan <vasanth@atheros.com>

    commit 1814077fd12a9cdf478c10076e9c42094e9d9250 upstream.

    On a 32-bit machine, BIT() macro does not give the required
    bit value if the bit is mroe than 31. In ieee802_11_parse_elems_crc(),
    BIT() is suppossed to get the bit value more than 31 (42 (id of ERP_INFO_IE),
    37 (CHANNEL_SWITCH_IE), (42), 32 (POWER_CONSTRAINT_IE), 45 (HT_CAP_IE),
    61 (HT_INFO_IE)). As we do not get the required bit value for the above
    IEs, crc over these IEs are never calculated, so any dynamic change in these
    IEs after the association is not really handled on 32-bit platforms.
    This patch fixes this issue.

    Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/mac80211/util.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/mac80211/util.c
    +++ b/net/mac80211/util.c
    @@ -579,7 +579,7 @@ u32 ieee802_11_parse_elems_crc(u8 *start
    if (elen > left)
    break;

    - if (calc_crc && id < 64 && (filter & BIT(id)))
    + if (calc_crc && id < 64 && (filter & (1ULL << id)))
    crc = crc32_be(crc, pos - 2, elen + 2);

    switch (id) {



    \
     
     \ /
      Last update: 2009-12-17 05:35    [W:0.020 / U:95.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site