lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[070/151] x86: Fix bogus warning in apic_noop.apic_write()
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Thomas Gleixner <tglx@linutronix.de>

    commit a946d8f11f0da9cfc714248036fcfd3a794d1e27 upstream.

    apic_noop is used to provide dummy apic functions. It's installed
    when the CPU has no APIC or when the APIC is disabled on the kernel
    command line.

    The apic_noop implementation of apic_write() warns when the CPU has
    an APIC or when the APIC is not disabled.

    That's bogus. The warning should only happen when the CPU has an
    APIC _AND_ the APIC is not disabled. apic_noop.apic_read() has the
    correct check.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Cyrill Gorcunov <gorcunov@openvz.org>
    LKML-Reference: <alpine.LFD.2.00.0912071255420.3089@localhost.localdomain>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/kernel/apic/apic.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/apic/apic.c
    +++ b/arch/x86/kernel/apic/apic.c
    @@ -246,7 +246,7 @@ static int modern_apic(void)
    */
    static void native_apic_write_dummy(u32 reg, u32 v)
    {
    - WARN_ON_ONCE((cpu_has_apic || !disable_apic));
    + WARN_ON_ONCE(cpu_has_apic && !disable_apic);
    }

    static u32 native_apic_read_dummy(u32 reg)



    \
     
     \ /
      Last update: 2009-12-17 05:35    [W:4.560 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site