lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[145/151] intel-iommu: Apply BIOS sanity checks for interrupt remapping too.
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: David Woodhouse <David.Woodhouse@intel.com>

    commit 6ecbf01c7ce4c0f4c3bdfa0e64ac6258328fda6c upstream.

    The BIOS errors where an IOMMU is reported either at zero or a bogus
    address are causing problems even when the IOMMU is disabled -- because
    interrupt remapping uses the same hardware. Ensure that the checks get
    applied for the interrupt remapping initialisation too.

    Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/pci/dmar.c | 33 ++++++++++++++++++++++++++-------
    1 file changed, 26 insertions(+), 7 deletions(-)

    --- a/drivers/pci/dmar.c
    +++ b/drivers/pci/dmar.c
    @@ -582,6 +582,8 @@ int __init dmar_table_init(void)
    return 0;
    }

    +static int bios_warned;
    +
    int __init check_zero_address(void)
    {
    struct acpi_table_dmar *dmar;
    @@ -612,6 +614,7 @@ int __init check_zero_address(void)
    dmi_get_system_info(DMI_BIOS_VENDOR),
    dmi_get_system_info(DMI_BIOS_VERSION),
    dmi_get_system_info(DMI_PRODUCT_VERSION));
    + bios_warned = 1;
    goto failed;
    }

    @@ -631,6 +634,7 @@ int __init check_zero_address(void)
    dmi_get_system_info(DMI_BIOS_VENDOR),
    dmi_get_system_info(DMI_BIOS_VERSION),
    dmi_get_system_info(DMI_PRODUCT_VERSION));
    + bios_warned = 1;
    goto failed;
    }
    }
    @@ -688,6 +692,18 @@ int alloc_iommu(struct dmar_drhd_unit *d
    int agaw = 0;
    int msagaw = 0;

    + if (!drhd->reg_base_addr) {
    + if (!bios_warned) {
    + WARN(1, "Your BIOS is broken; DMAR reported at address zero!\n"
    + "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
    + dmi_get_system_info(DMI_BIOS_VENDOR),
    + dmi_get_system_info(DMI_BIOS_VERSION),
    + dmi_get_system_info(DMI_PRODUCT_VERSION));
    + bios_warned = 1;
    + }
    + return -EINVAL;
    + }
    +
    iommu = kzalloc(sizeof(*iommu), GFP_KERNEL);
    if (!iommu)
    return -ENOMEM;
    @@ -704,13 +720,16 @@ int alloc_iommu(struct dmar_drhd_unit *d
    iommu->ecap = dmar_readq(iommu->reg + DMAR_ECAP_REG);

    if (iommu->cap == (uint64_t)-1 && iommu->ecap == (uint64_t)-1) {
    - /* Promote an attitude of violence to a BIOS engineer today */
    - WARN(1, "Your BIOS is broken; DMAR reported at address %llx returns all ones!\n"
    - "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
    - drhd->reg_base_addr,
    - dmi_get_system_info(DMI_BIOS_VENDOR),
    - dmi_get_system_info(DMI_BIOS_VERSION),
    - dmi_get_system_info(DMI_PRODUCT_VERSION));
    + if (!bios_warned) {
    + /* Promote an attitude of violence to a BIOS engineer today */
    + WARN(1, "Your BIOS is broken; DMAR reported at address %llx returns all ones!\n"
    + "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
    + drhd->reg_base_addr,
    + dmi_get_system_info(DMI_BIOS_VENDOR),
    + dmi_get_system_info(DMI_BIOS_VERSION),
    + dmi_get_system_info(DMI_PRODUCT_VERSION));
    + bios_warned = 1;
    + }
    goto err_unmap;
    }




    \
     
     \ /
      Last update: 2009-12-17 05:11    [W:2.121 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site