Messages in this thread | | | Subject | Re: [PATCH] Libertas: fix buffer overflow in lbs_get_essid() | From | Dan Williams <> | Date | Wed, 16 Dec 2009 17:19:12 -0800 |
| |
On Wed, 2009-12-16 at 20:01 -0500, John W. Linville wrote: > On Thu, Dec 17, 2009 at 07:15:08AM +0800, Daniel Mack wrote: > > On Wed, Dec 16, 2009 at 08:57:47AM -0800, Dan Williams wrote: > > > On Wed, 2009-12-16 at 05:12 +0100, Daniel Mack wrote: > > > > The libertas driver copies the SSID buffer back to the wireless core and > > > > appends a trailing NULL character for termination. This is > > > > > > > > a) unnecessary because the buffer is allocated with kzalloc and is hence > > > > already NULLed when this function is called, and > > > > > > > > b) for priv->curbssparams.ssid_len == 32, it writes back one byte too > > > > much which causes memory corruptions. > > > > > > > > Fix this by removing the extra write. > > > > > > Acked-by: Dan Williams <dcbw@redhat.com> > > > > Thanks, everyone. Who will care to pick an queue this one? > > Is there some reason it wouldn't be me?
No, it should be you. Please suck it into your 2.6.33 patchset and we'll cc to stable when it hits linus I guess.
Dan
| |