lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[88/90] thinkpad-acpi: fix default brightness_mode for R50e/R51
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

    commit a9f8eacca4e9e8693de9b896c1fa7aadaa9402e8 upstream.

    According to a report, the R50e wants EC-based brightness control,
    even if it uses an Intel GPU. The current driver default was reported
    to not work at all.

    This bug can be worked around by the "brightness_mode=3" module
    parameter.

    Change the default of the R50e and R51 2xxx models (which use the same
    EC firmware, 1V) to TPACPI_BRGHT_Q_EC, but keep TPACPI_BRGHT_Q_ASK set
    for now, as I'd like to get more reports.

    This fixes a regression caused by commit
    59fe4fe34d7afdf63208124f313be9056feaa2f4,
    "thinkpad-acpi: fix incorrect use of TPACPI_BRGHT_MODE_ECNVRAM"

    Kernel 2.6.31 also needs this fix.

    Reported-by: Ferenc Wagner <wferi@niif.hu>
    Tested-by: Ferenc Wagner <wferi@niif.hu>
    Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
    Cc: stable@kernel.org
    Signed-off-by: Len Brown <len.brown@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/platform/x86/thinkpad_acpi.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/platform/x86/thinkpad_acpi.c
    +++ b/drivers/platform/x86/thinkpad_acpi.c
    @@ -5663,8 +5663,8 @@ static const struct tpacpi_quirk brightn

    /* Models with Intel Extreme Graphics 2 */
    TPACPI_Q_IBM('1', 'U', TPACPI_BRGHT_Q_NOEC),
    - TPACPI_Q_IBM('1', 'V', TPACPI_BRGHT_Q_ASK|TPACPI_BRGHT_Q_NOEC),
    - TPACPI_Q_IBM('1', 'W', TPACPI_BRGHT_Q_ASK|TPACPI_BRGHT_Q_NOEC),
    + TPACPI_Q_IBM('1', 'V', TPACPI_BRGHT_Q_ASK|TPACPI_BRGHT_Q_EC),
    + TPACPI_Q_IBM('1', 'W', TPACPI_BRGHT_Q_ASK|TPACPI_BRGHT_Q_EC),

    /* Models with Intel GMA900 */
    TPACPI_Q_IBM('7', '0', TPACPI_BRGHT_Q_NOEC), /* T43, R52 */



    \
     
     \ /
      Last update: 2009-12-17 02:25    [W:0.023 / U:31.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site