lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 03/12] sched: Fix task_hot() test order
    Make sure not to access sched_fair fields before verifying it is
    indeed a sched_fair task.

    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    CC: stable@kernel.org
    ---
    kernel/sched.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    Index: linux-2.6/kernel/sched.c
    ===================================================================
    --- linux-2.6.orig/kernel/sched.c
    +++ linux-2.6/kernel/sched.c
    @@ -2044,6 +2044,9 @@ task_hot(struct task_struct *p, u64 now,
    {
    s64 delta;

    + if (p->sched_class != &fair_sched_class)
    + return 0;
    +
    /*
    * Buddy candidates are cache hot:
    */
    @@ -2052,9 +2055,6 @@ task_hot(struct task_struct *p, u64 now,
    &p->se == cfs_rq_of(&p->se)->last))
    return 1;

    - if (p->sched_class != &fair_sched_class)
    - return 0;
    -
    if (sysctl_sched_migration_cost == -1)
    return 1;
    if (sysctl_sched_migration_cost == 0)
    --



    \
     
     \ /
      Last update: 2009-12-16 18:09    [W:0.019 / U:3.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site