lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC, PATCH 1/4] cleanup elf_core_dump(): remove ELF_CORE_EXTRA_* macro
    From
    From: Masami Hiramatsu <mhiramat@redhat.com>
    Subject: Re: [RFC, PATCH 1/4] cleanup elf_core_dump(): remove ELF_CORE_EXTRA_* macro
    Date: Tue, 15 Dec 2009 10:14:21 -0500

    > Daisuke HATAYAMA wrote:
    > > elf_core_dump() uses #ifdef and the corresponding macro for hiding
    > > _multiline_ logics in functions. This patch removes #ifdef and
    > > replaces ELF_CORE_EXTRA_* by corresponding functions. For
    > > architectures not implemeonting ELF_CORE_EXTRA_*, we use weak
    > > functions in order to reduce a range of modification.
    > >
    > > This cleanup is for my next patches, but I think this cleanup itself
    > > is worth doing regardless of my firnal purpose.
    > >
    > > Signed-off-by: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
    > > ---
    > > arch/ia64/kernel/Makefile | 2 +
    > > arch/ia64/kernel/elfcore.c | 75 ++++++++++++++++++++++++++++++++++++++++++
    > > arch/um/sys-i386/Makefile | 2 +
    > > arch/um/sys-i386/elfcore.c | 78 ++++++++++++++++++++++++++++++++++++++++++++
    > > fs/binfmt_elf.c | 36 +++++++++++++++-----
    > > include/linux/elf.h | 2 +
    >

    > Hmm, why don't you remove ELF_CORE_EXTRA_* macros too??
    > And also, you have to update fs/binfmt_elf_fdpic.c too.
    >
    > Thank you,

    The reason relates to the fact that elf_core_extra_* functions for
    architectures with no extra data are defined as the weak ones. As I've
    written in the patch description, they are useful to reduce a range of
    modification.

    If I modify fs/binfmt_elf.c, I need to prepare another file in order
    for binfmt_elf{,_fdpic}.c to share the weak functions. (Now the week
    functions are defined in fs/binfmt_elf.c.)

    The problem is that I don't know where to put new file elfcore.c for
    weak functions. I am not familiar with such convension.

    For example, is it right to put fs/elfcore.c or kernel/elfcore.c?

    Thanks.


    \
     
     \ /
      Last update: 2009-12-16 05:11    [W:0.022 / U:30.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site