Messages in this thread | | | Subject | Re: [folded] kernelh-add-printk_ratelimited-and-pr_level_rl-rename.patch removed from -mm tree | From | Valdis.Kletnieks@vt ... | Date | Tue, 15 Dec 2009 17:44:55 -0500 |
| |
On Tue, 15 Dec 2009 11:28:02 +0100, Peter Zijlstra said: > On Mon, 2009-12-14 at 17:08 -0800, akpm@linux-foundation.org wrote: > > s/_rl/_ratelimited/g > > do we feel this pr_* wankery is worth the hassle? I'd as soon send a > patch removing all this crap.
pr_foo() instead of printk(KERN_FOO) is probably worth the hassle, as it allows more selective inclusion of messages if you're trying to build an embedded kernel. It's easy to say "I want pr_warning() to stay in, but lower levels compile to nothing". Trying to keep a 'printk(KERN_WARNING' while making a printk(KERN_DEBUG go away is just asking for some truly astounding pre-processor gyrations.
Not an issue for my laptop with 4G of RAM - byt my cell phone says it has 26M of memory, 7M used (presumably all the software, my contact list isn't *that* big). No idea what the actual kernel is, but I know whatever it is, the coders were using that kernel's equivalent of CONFIG_EMBEDDED and tossing stuff over the side if they didn't need it. ;)
[unhandled content-type:application/pgp-signature] | |