Messages in this thread | | | Date | Tue, 15 Dec 2009 10:14:21 -0500 | From | Masami Hiramatsu <> | Subject | Re: [RFC, PATCH 1/4] cleanup elf_core_dump(): remove ELF_CORE_EXTRA_* macro |
| |
Daisuke HATAYAMA wrote: > elf_core_dump() uses #ifdef and the corresponding macro for hiding > _multiline_ logics in functions. This patch removes #ifdef and > replaces ELF_CORE_EXTRA_* by corresponding functions. For > architectures not implemeonting ELF_CORE_EXTRA_*, we use weak > functions in order to reduce a range of modification. > > This cleanup is for my next patches, but I think this cleanup itself > is worth doing regardless of my firnal purpose. > > Signed-off-by: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com> > --- > arch/ia64/kernel/Makefile | 2 + > arch/ia64/kernel/elfcore.c | 75 ++++++++++++++++++++++++++++++++++++++++++ > arch/um/sys-i386/Makefile | 2 + > arch/um/sys-i386/elfcore.c | 78 ++++++++++++++++++++++++++++++++++++++++++++ > fs/binfmt_elf.c | 36 +++++++++++++++----- > include/linux/elf.h | 2 +
Hmm, why don't you remove ELF_CORE_EXTRA_* macros too?? And also, you have to update fs/binfmt_elf_fdpic.c too.
Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |