lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [this_cpu_xx V7 6/8] Make slub statistics use this_cpu_inc
    On Tue, 15 Dec 2009, Eric Dumazet wrote:

    > Le 14/12/2009 23:03, Christoph Lameter a écrit :
    > > this_cpu_inc() translates into a single instruction on x86 and does not
    > > need any register. So use it in stat(). We also want to avoid the
    > > calculation of the per cpu kmem_cache_cpu structure pointer. So pass
    > > a kmem_cache pointer instead of a kmem_cache_cpu pointer.
    > >
    >
    > Hmm, last time I checked, [__]this_cpu_inc were not using "inc" on x86,
    > but the default [__]this_cpu_add((pcp), 1)

    Well the add 1 is still a single instruction so its okay. We can easily
    add support for inc on x86 if makes a difference?




    \
     
     \ /
      Last update: 2009-12-15 15:51    [W:3.849 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site