Messages in this thread | | | Date | Tue, 15 Dec 2009 13:17:21 +0100 | From | Stefan Seyfried <> | Subject | Re: [PATCH 0/2] Add support for Sphairon Homelink 1202 USB WLAN |
| |
On Fri, 11 Dec 2009 23:37:09 +0100 Stefan Seyfried <stefan.seyfried@googlemail.com> wrote: > On Fri, 11 Dec 2009 11:21:10 -0800 > Dan Williams <dcbw@redhat.com> wrote: > > place to put this code is probably unusual_devs instead of > > touching /two/ drivers. I'd say extract the code from zd1211rw and put > > the new code that works for both zd1211rw/ar9170 into unusual_devs. In > > fact, people might be happier if you posted two patches, (1) move the > > code to unusual_devs unchanged,
Done. Was easier than I had expected and resulted in a nice reduction in lines of code, because usb storage code has all infrastructure to handle the device, which zd1211rw had hand-crafted.
> and (2) fix up the moved code to support > > the new device's behavior.
This was actually not necessary, because the usb-storage infrastructure automatically chooses the correct endpoint :-)
See the mail Subject: [PATCH] move eject code from zd1211rw to usb-storage
Thanks for review and suggestions,
Stefan
-- "You sure you software suspend guys haven't been hanging out with the IDE maintainers?" -- Rob Landley, during one of the suspend wars
| |