Messages in this thread | | | Date | Tue, 15 Dec 2009 18:20:35 +0800 | From | Daniel Mack <> | Subject | Re: [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs |
| |
On Tue, Dec 15, 2009 at 11:07:14AM +0100, Johannes Berg wrote: > On Tue, 2009-12-15 at 11:03 +0100, Johannes Berg wrote: > > > Since you indicate the kernel crashed, it is likely that libertas is > > treating the buffer as a string, instead of an SSID.
Ok, I dodn't know that - thanks for pointing it out. In my setup here, SSIDs are always valid alphanumeric strings, and I was mislead by the comment that mentions the NULL-termination.
> drivers/net/wireless/libertas$ grep lbs_deb_ * | grep ssid|grep '%s' > assoc.c: lbs_deb_join("current SSID '%s', ssid length %u\n", > assoc.c: lbs_deb_join("requested ssid '%s', ssid length %u\n", > assoc.c: lbs_deb_join("ADHOC_START: SSID '%s', ssid length %u\n", > scan.c: lbs_deb_wext("set_scan, essid '%s'\n",
Those macros are stubbed out as nops in my setup, so they can unfortunately not be the reason. I'll dig deeper :)
Thanks, Daniel
| |