lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: linux-next: ext3 tree build warning
    From
    2009/12/15 Stephen Rothwell <sfr@canb.auug.org.au>:
    > Hi Jan,
    >
    > Today's linux-next build (x86_64 allmodconfig) produced this warning:
    >
    > fs/quota/dquot.c: In function 'dquot_alloc_inode':
    > fs/quota/dquot.c:1521: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
    > fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
    > fs/quota/dquot.c: In function 'dquot_free_inode':
    > fs/quota/dquot.c:1649: warning: passing argument 1 of 'mark_all_dquot_dirty' discards qualifiers from pointer target type
    > fs/quota/dquot.c:327: note: expected 'struct dquot **' but argument is of type 'struct dquot * const*'
    What's why my original patch contained type casts.
    In fact i dont understand why {alloc,free}_inode accept pointer to
    const struct inode, it's contradicts to normal logic
    Even if inode is not in a good state, quta code may and must(what's
    how it designed for now) change it internals.
    >
    > Introduced by commit e91077e3d523c2ac2090b3447bf6244567cf7128 ("quota:
    > Move duplicated code to separate functions").
    >
    > --
    > Cheers,
    > Stephen Rothwell                    sfr@canb.auug.org.au
    > http://www.canb.auug.org.au/~sfr/
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-15 11:01    [W:0.023 / U:32.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site