[lkml]   [2009]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v4.2
On Tue, 15 Dec 2009, KAMEZAWA Hiroyuki wrote:

> > That's not at all what I said. I said using total_vm as a baseline allows
> > users to define when a process is to be considered "rogue," that is, using
> > more memory than expected. Using rss would be inappropriate since it is
> > highly dynamic and depends on the state of the VM at the time of oom,
> > which userspace cannot possibly keep updated.
> >
> > You consistently ignore that point: the power of /proc/pid/oom_adj to
> > influence when a process, such as a memory leaker, is to be considered as
> > a high priority for an oom kill. It has absolutely nothing to do with
> > fake NUMA, cpusets, or memcg.
> >
> You also ignore that it's not sane to use oom kill for resource control ;)

Please read my email. Did I say anything about resource control AT ALL?
I said /proc/pid/oom_adj currently allows userspace to define when a task
is "rogue," meaning its consuming much more memory than expected. Those
memory leakers should always be the optimal result for the oom killer to
kill. Using rss as the baseline would not allow userspace to effectively
do the same thing since it's dynamic and depends on the state of the VM at
the time of oom which is probably not reflected in the /proc/pid/oom_adj
values for all tasks. It has absolutely nothing to do with resource
control, so please address this very trivial issue without going off on
tangents. Thanks.

 \ /
  Last update: 2009-12-15 06:01    [W:0.128 / U:0.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site