lkml.org 
[lkml]   [2009]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: PATCH v2 3/4] Defer skb allocation -- new recvbuf alloc & receive calls
    From
    Date
    Hello Michael,

    On Mon, 2009-12-14 at 14:08 -0800, Shirley Ma wrote:
    > > > +
    > > > + err = vi->rvq->vq_ops->add_buf(vi->rvq, sg, 0, 2, skb);
    > > > + if (err < 0)
    > > > + kfree_skb(skb);
    > > > + else
    > > > + skb_queue_head(&vi->recv, skb);
    > >
    > > So why are we queueing this still?
    > This is for small packet. I didn't change that code since it will
    > involve extra copy by using page.

    I think I can remove skb link for small packet as well by adding
    kfree_skb() in virtio_net_free_bufs for small packet.

    Thanks
    Shirley



    \
     
     \ /
      Last update: 2009-12-15 01:39    [W:0.033 / U:29.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site