Messages in this thread | | | Subject | Re: PATCH v2 3/4] Defer skb allocation -- new recvbuf alloc & receive calls | From | Shirley Ma <> | Date | Mon, 14 Dec 2009 16:37:15 -0800 |
| |
Hello Michael,
On Mon, 2009-12-14 at 14:08 -0800, Shirley Ma wrote: > > > + > > > + err = vi->rvq->vq_ops->add_buf(vi->rvq, sg, 0, 2, skb); > > > + if (err < 0) > > > + kfree_skb(skb); > > > + else > > > + skb_queue_head(&vi->recv, skb); > > > > So why are we queueing this still? > This is for small packet. I didn't change that code since it will > involve extra copy by using page.
I think I can remove skb link for small packet as well by adding kfree_skb() in virtio_net_free_bufs for small packet.
Thanks Shirley
| |