lkml.org 
[lkml]   [2009]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)
Hi,

On Mon, Dec 14, 2009 at 10:22:32PM +0100, ext Rick L. Vinyard Jr. wrote:
>
>Signed-off-by: Rick L. Vinyard, Jr <rvinyard@cs.nmsu.edu>

there are plenty of style mistakes in this patch. the body message
description which you put below should be above the signed-off-by line,
multi-lined comments are of the form:

/*
* multi lined comment
* goes here
*/

remove the commented code like /* hid_debug = 0 */

and some others.. please run your patch through scripts/checkpatch.pl
--strict and fix the errors and warnings reported.

please take a look at Documentation/SubmittingPatches and
Documentation/CodingStyle for further reference.

When sending the patch, you could also use git send-email to avoid the
problem you had with 'mail'.

>+static int __init g13_init(void)
>+{
>+ pr_debug("g13 HID driver loaded");

don't pr_debug() here.

>+ return hid_register_driver(&g13_driver);
>+}
>+
>+static void __exit g13_exit(void)
>+{
>+ pr_debug("g13 HID driver unloaded");

nor here.

>+ hid_unregister_driver(&g13_driver);
>+}

--
balbi


\
 
 \ /
  Last update: 2009-12-14 23:05    [W:0.159 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site