Messages in this thread | | | Date | Mon, 14 Dec 2009 14:50:58 -0500 | From | Neil Horman <> | Subject | Re: [PATCH] Fix tracing infrastructure to support multiple includes when defining CREATE_TRACE_POINTS |
| |
On Mon, Dec 07, 2009 at 03:53:41PM -0500, Neil Horman wrote: > On Mon, Dec 07, 2009 at 03:49:26PM -0500, Steven Rostedt wrote: > > On Mon, 2009-12-07 at 15:47 -0500, Steven Rostedt wrote: > > > > > > > > > > Note this patch also converts the napi_poll tracepoint to a TRACE_EVENT. This > > > > is done so that the TRACE_EVENT fix doesn't break the build, and because its > > > > rather pointless I think given the current tracing infrastructure to not have > > > > napi_poll be an independent event. > > > > > > > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > > > > > > Thanks, I'll give it a test. But because this now touches networking > > > code, I need an Acked-by from David Miller before I can pull it in. > > > > > > -- Steve > > > > > > > > > > > > > > > > > > > > > linux/tracepoint.h | 45 +++++++++++++++++++++++---------------------- > > > > trace/define_trace.h | 1 + > > > > trace/events/napi.h | 25 ++++++++++++++++++++++--- > > > > Hmm, This really isn't networking code. But still, a patch that changes > > the way a networking trace point works, I would rather have an ack. > > > > Thanks, > > > Copy that, I agree an Ack from dave is called for here, but Just FYi, theres > only one user of this tracepoint currently in the tree (the drop monitor) and > this change has no bearing on it, as you can still hook the tracepoint with the > same register_trace_napi_poll call > > Neil > Ping, Dave, any thoughts here? Regards Neil
| |