lkml.org 
[lkml]   [2009]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] laptop-mode: Make flushes per-device
On Sat, Dec 12, 2009 at 01:24:43PM +0100, Jens Axboe wrote:

> That's because it is messy, why are you passing the request in? It
> would be a lot more sane to pass in the queue, better still the backing
> device.

It seemed conceptually cleaner for the completion to refer to the
request rather than anything else, but that's easily fixed.

> What guarentees that the timer isn't running when the bdi goes away?

Good point. I'll fix these and resend.

--
Matthew Garrett | mjg59@srcf.ucam.org

\
 
 \ /
  Last update: 2009-12-14 20:09    [from the cache]
©2003-2011 Jasper Spaans