Messages in this thread |  | | | Date | Mon, 14 Dec 2009 08:04:52 -0800 | | From | Arjan van de Ven <> | | Subject | Re: [PATCH 2/8] Mark sleep_on as deprecated |
| |
On Mon, 14 Dec 2009 08:03:02 -0500 Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Dec 14, 2009 at 09:24:40PM +0900, KOSAKI Motohiro wrote: > > > > > > sleep_on() function is SMP and/or kernel preemption unsafe. we > > shouldn't use it on new code. > > And the best way to archive this is to remove the function. > > In Linus' current tree I find: > > - 5 instances of sleep_on(), all in old and obscure block drivers > - 2 instances of sleep_on_timeout(), both in old and obscure drivers
these should both die; the sleep_on() ones using BROKEN in Kconfig.. .. sleep_on() has not worked in the 2.6 series ever.... ;)
> > - 28 instances of interruptible_sleep_on_timeout(), mostly in obscure > drivers with a high concentration in the old oss core which should > be killed anyway. And unfortunately a few relatively recent additions > like the SGI xpc driver or usbvision driver
can we also make sure that checkpatch.pl catches any new addition? (not saying checkpatch.pl is the end-all, but the people who do run it at least have now have a chance ;-)
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
|  |