Messages in this thread | | | Date | Mon, 14 Dec 2009 06:56:31 +0100 | From | Eric Dumazet <> | Subject | Re: Badness at net/ipv4/inet_connection_sock.c:293 |
| |
Le 12/12/2009 10:22, Eric Dumazet a écrit : > Le 12/12/2009 10:03, David Miller a écrit : >> From: Christian Kujau <lists@nerdbynature.de> >> Date: Fri, 11 Dec 2009 23:43:10 -0800 (PST) >> >>> today I upgraded from 2.6.32-rc7 to the latest -git (mainline) and after a >>> few hours the messages below appeared in the log. Apparently "privoxy" was >>> very busy handling connections, but the messages never appeared with >>> earlier kernels. >>> >>> Full dmesg & .config is on: >>> http://nerdbynature.de/bits/2.6.33-git/inet_accept/ >> >> Yeah I started seeing this on one of my machines too, the >> assertion is: >> >> WARN_ON(newsk->sk_state == TCP_SYN_RECV); >> >> I wonder if some of the refactorings we did to allow per-route >> SACK/DSACK/etc. controls messed some sequence of state changes >> on TCP sockets. But I can't find anything obvious in those >> commits. > > Could it be about syncookies patches ? > > tcp_create_openreq_child() changes ? >
It seems to me tcp_create_openreq_child() doesnt properly initialize newtp->cookie_values to NULL, but this should not produce warnings like that ?
Sorry to not provides a proper patch now, I have to run...
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |