lkml.org 
[lkml]   [2009]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] can: CAN_MCP251X should depend on HAS_DMA
Geert Uytterhoeven wrote:
> When building for Sun 3:
>
> drivers/net/can/mcp251x.c:1074: undefined reference to `dma_free_coherent'
> drivers/net/can/mcp251x.c:976: undefined reference to `dma_alloc_coherent'
> drivers/net/can/mcp251x.c:1050: undefined reference to `dma_free_coherent'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/can/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> index 8c485aa..05b7517 100644
> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -50,7 +50,7 @@ config CAN_TI_HECC
>
> config CAN_MCP251X
> tristate "Microchip MCP251x SPI CAN controllers"
> - depends on CAN_DEV && SPI
> + depends on CAN_DEV && SPI && HAS_DMA
> ---help---
> Driver for the Microchip MCP251x SPI CAN controllers.
>

DMA can be selected with the module parameter "mcp251x_enable_dma" and
is *off* by default. Therefore the driver does in principle not depend
on HAS_DMA but I'm not sure if it's worth to handle it with #idef's.
Christian? Any thought?

Wolfgang.



\
 
 \ /
  Last update: 2009-12-13 21:51    [W:0.100 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site