Messages in this thread | | | Date | Sun, 13 Dec 2009 20:56:07 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register. |
| |
On Sat, Dec 12, 2009 at 05:48:43PM +0100, Alberto Panizzo wrote: > MC13783_REGCTRL_PWGTnSPIEN controls the states of the corresponding > PWGTn_DRV output. > Reading 1 on the corresponding bit mean that the output is enabled > Writing 1 on the corresponding bit disable that output! > > So, if not asked directly to modify those bits, write the inverted > value. Hmm, I'm not sure this completely right. The Spec has:
Bit PWGTxSPIEN | Pin PWGTxEN | PWGTxDRV | Read Back 0 = default | | | PWGTxSPIEN ---------------+-------------+----------+------------ 1 | x | Low | 0 0 | 0 | High | 1 0 | 1 | Low | 0
So it looks a bit harder than just inverting the read bit.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |