[lkml]   [2009]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] laptop-mode: Make flushes per-device
On Fri, Dec 11 2009, Matthew Garrett wrote:
> One of the features of laptop-mode is that it forces a writeout of dirty
> pages if something else triggers a physical read or write from a device.
> The current implementation flushes pages on all devices, rather than only
> the one that triggered the flush. This patch alters the behaviour so that
> only the recently accessed block device is flushed, preventing other
> disks being spun up for no terribly good reason.
> Signed-off-by: Matthew Garrett <>
> ---
> The forward struct declaration in writeback.h seems messy, but I'm not
> sure there's a cleaner way to do this. I'm also still woefully
> unfamiliar with the block layer - I /think/ this does the right thing,
> but some review would be nice.

That's because it is messy, why are you passing the request in? It
would be a lot more sane to pass in the queue, better still the backing

What guarentees that the timer isn't running when the bdi goes away?

Jens Axboe

 \ /
  Last update: 2009-12-12 13:27    [W:0.051 / U:0.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site