lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] tracing: Define kmem_trace_alloc_notrace unconditionally
    于 2009年12月11日 14:01, Pekka Enberg 写道:
    > Pekka Enberg wrote:
    >> Li Zefan wrote:
    >>> Always define kmem_trace_alloc_{,node}_notrace(), otherwise
    >>> perf-kmem will show wrong stats ifndef CONFIG_KMEMTRACE,
    >>> because a kmalloc() memory allocation may be traced by
    >>> both trace_kmalloc() and trace_kmem_cache_alloc().
    >>>
    >>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    >>
    >> Did you check how much this will make kernel text bigger because of
    >> the inlining happening in kmem_cache_alloc_notrace()?
    >
    > Maybe use CONFIG_TRACING instead of CONFIG_KMEMTRACE here like in the
    > other patch?
    >

    Wouldn't removing CONFIG_KMEMTRACE make the code cleaner?
    Anyway, if CONFIG_TRACING is not enabled, all the trace_xxx()
    will be turned into no-op.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-11 07:15    [W:0.020 / U:60.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site