lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 56/58] tty: Push the bkl down a bit in the hangup code
    Date
    From: Alan Cox <alan@linux.intel.com>

    We know that the redirect field is handled via its own locking in all
    places

    Signed-off-by: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/char/tty_io.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
    index c408c81..cc941a3 100644
    --- a/drivers/char/tty_io.c
    +++ b/drivers/char/tty_io.c
    @@ -505,8 +505,6 @@ static void do_tty_hangup(struct work_struct *work)
    if (!tty)
    return;

    - /* inuse_filps is protected by the single kernel lock */
    - lock_kernel();

    spin_lock(&redirect_lock);
    if (redirect && redirect->private_data == tty) {
    @@ -515,6 +513,8 @@ static void do_tty_hangup(struct work_struct *work)
    }
    spin_unlock(&redirect_lock);

    + /* inuse_filps is protected by the single kernel lock */
    + lock_kernel();
    check_tty_count(tty, "do_tty_hangup");
    file_list_lock();
    /* This breaks for file handles being sent over AF_UNIX sockets ? */
    --
    1.6.5.5


    \
     
     \ /
      Last update: 2009-12-12 00:35    [W:0.019 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site