Messages in this thread | | | Date | Thu, 10 Dec 2009 09:02:40 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] sched: Memory leak in two error corner cases |
| |
* Phil Carmody <ext-phil.2.carmody@nokia.com> wrote:
> --- a/kernel/sched.c > +++ b/kernel/sched.c > @@ -9841,8 +9841,10 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent) > > se = kzalloc_node(sizeof(struct sched_entity), > GFP_KERNEL, cpu_to_node(i)); > - if (!se) > + if (!se) { > + kfree(cfs_rq); > goto err; > + }
would be nice to turn this into a regular pattern of:
if (!se) goto err_kfree;
where err_kfree does the kfree.
Thanks,
Ingo
| |