Messages in this thread | | | Date | Thu, 10 Dec 2009 23:20:41 +0000 | From | Phillip Lougher <> | Subject | Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file |
| |
Geert Uytterhoeven wrote: > Hi Phillip, > > On Thu, Dec 10, 2009 at 01:38, Phillip Lougher > <phillip@lougher.demon.co.uk> wrote: >> Artem Bityutskiy wrote: >>> Did you consider using cryptoapi? UBIFS uses zlib/lzo in cryptoapi - it >>> is a very clean way. > > Exactly my question, as that's why the Crypto API was extended with > support for partial (de)compression in the first place ;-) >
Your cryptoapi patches are on my "must do something about them" list, I've not forgotten them :-) The lack of lzma in the crypotapi made moving solely to the cryptoapi difficult, when I wanted to add lzma decompression support.
The decompressor framework is my _solution_ to this problem. This allows cryptoapi support to be added as additional decompression_wrapper, with multiple compression types using the crptoapi wrapper as appropriate. This has the advantage it allows Squashfs to use the cryptoapi (with its advantages), without needlessly restricting Squashfs to the compression algorithms supported by the cryptoapi.
Let's get this mainlined, and then we can work on getting your cryptoapi patches integrated into that. That'll make me happy, and hopefully you'll be happy too?
Thanks
Phillip
| |