Messages in this thread | | | Date | Thu, 10 Dec 2009 17:00:04 +0000 | Subject | Re: PATCH: Toshiba Bluetooth enabler (v3) | From | Alan Jenkins <> |
| |
On 12/10/09, Jes Sorensen <jes.sorensen@gmail.com> wrote: > On 12/09/2009 02:17 PM, Alan Jenkins wrote: >>> Fixed, this version only calls the enabler if the switch is at ON at >>> resume time. >> >> Ah... I think add() has the same problem as well though? I.e. the >> driver will not work if the switch is disabled at load time. >> >> I would change it in enable() (and then try to think of a new name for >> it, maybe try_enable()). > > Sorta did that, it should do the right thing in all those cases now.
Great, looks good.
> Otherwise I am pretty pleased with it now. Unless there's strong > objections, I'd say it's good to go. > > Cheers, > Jes
I did question "depends on RFKILL". If you manually configure a kernel, you will miss "If you have a modern Toshiba laptop with a Bluetooth and an RFKill switch (such as the Portege R500), say Y." unless you enable RFKILL first. (Which is unnecessary since the driver will work exactly the same with RFKILL=n). I wouldn't call it a strong objection, but it would be nice to hear the reason you included this dependency.
Everything else looks fine. Thanks for working on this. Alan
| |