Messages in this thread | | | Date | Tue, 01 Dec 2009 09:23:23 +0000 | From | Ian Molton <> | Subject | Re: [PATCH 1/2] hw_random: core updates to allow more efficient drivers |
| |
Rusty Russell wrote:
> But we're bikeshedding, so apply or revert. > > /* A buffer which can hold any fundamental type: drivers are fussy. */ > static u8 rng_buffer[SMP_CACHE_BYTES < 8 ? 8 : SMP_CACHE_BYTES] > __cacheline_aligned;
One nit - theres one driver where <24 bytes will be quite suboptimal. I'd say pick 32 bytes, which is a common cachline size, too.
> Either way, both patches: Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks!
-Ian
| |