lkml.org 
[lkml]   [2009]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BUGFIX -v2 for .32] crypto, gcm, fix another complete call in complete fuction
    On Tue, Nov 10, 2009 at 10:49:59AM +0800, Huang Ying wrote:
    >
    > Yes. This is for performance only. Because crypto_gcm_reqctx(req) is not
    > so trivial (it needs access tfm), and used by every xxx_done function,
    > so I think it is better to just call crypto_gcm_reqctx once and pass it
    > down. Do you think so?

    Since we only support blocksize == 16, that means the alignment
    cannot exceed 16 bytes. So just always align to 16 bytes and that
    should make crypto_gcm_reqctx trivial once optimised by the
    compiler.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2009-11-10 04:13    [W:2.269 / U:1.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site