Messages in this thread |  | | | Date | Tue, 10 Nov 2009 05:11:20 +0900 | | Subject | Re: [PATCH 01/10] Add iommu_init to x86_init_ops | | From | FUJITA Tomonori <> |
| |
On Mon, 9 Nov 2009 22:02:24 +0200 Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On Wed, Oct 28, 2009 at 8:47 AM, FUJITA Tomonori > <fujita.tomonori@lab.ntt.co.jp> wrote: > > We call the detections functions of all the IOMMUs then all their > > initialization functions. THe latter is pointless since we don't > > detect multiple different IOMMUs. What we need to do is calling the > > initialization function of the detected IOMMU. > > > > This adds iommu_init hook to x86_init_ops so if an IOMMU detection > > function can set its initialization function to the hook. > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> > > --- > > arch/x86/include/asm/iommu.h | 1 + > > arch/x86/include/asm/x86_init.h | 9 +++++++++ > > arch/x86/kernel/pci-dma.c | 2 ++ > > arch/x86/kernel/x86_init.c | 5 +++++ > > 4 files changed, 17 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/include/asm/iommu.h b/arch/x86/include/asm/iommu.h > > index fd6d21b..42aa977 100644 > > --- a/arch/x86/include/asm/iommu.h > > +++ b/arch/x86/include/asm/iommu.h > > @@ -3,6 +3,7 @@ > > > > extern void pci_iommu_shutdown(void); > > extern void no_iommu_init(void); > > +static inline int iommu_init_noop(void) { return 0; } > > Why is this function not put in x86_init.c?
If it's fine by x86 maintainers, I'll do in the next version. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |