lkml.org 
[lkml]   [2009]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -v6 08/13] tracing: add IRQENTRY_EXIT section for MIPS
    On Mon, Oct 26, 2009 at 11:13:25PM +0800, Wu Zhangjin wrote:
    > This patch add a new section for MIPS to record the block of the hardirq
    > handling for function graph tracer(print_graph_irq) via adding the
    > __irq_entry annotation to the the entrypoints of the hardirqs(the block
    > with irq_enter()...irq_exit()).
    >
    > Thanks goes to Steven & Frederic Weisbecker for their feedbacks.
    >
    > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
    > +
    > +/*
    > + * do_IRQ handles all normal device IRQ's (the special
    > + * SMP cross-CPU interrupts have their own specific
    > + * handlers).
    > + */
    > +unsigned int __irq_entry do_IRQ(unsigned int irq)
    > +{
    > + irq_enter();
    > + __DO_IRQ_SMTC_HOOK(irq);
    > + generic_handle_irq(irq);
    > + irq_exit();
    > +
    > + return 1;
    > +}



    Nano-neat:

    Why is it returning a value, it doesn't seem needed (the macro
    version didn't)?

    Anyway, that looks good to me. I hope the changes from macro
    to function calls will be ack by the MIPS maintainers.

    Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>



    \
     
     \ /
      Last update: 2009-11-09 03:29    [W:0.047 / U:30.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site