Messages in this thread |  | | | Date | Sun, 08 Nov 2009 00:28:15 -0800 (PST) | | Subject | Re: [PATCH] sparc,sparc64: replace parentheses in pmul() | | From | David Miller <> |
From: Roel Kluin <roel.kluin@gmail.com> Date: Thu, 05 Nov 2009 17:40:44 +0100
> `>>' has a higher precedence than `?' so src2 evaluated to > either 16 or 0 dependent on the bits set in rs2. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > arch/sparc/kernel/visemul.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > I am not 100% sure that the code was incorrect, however, if it > was intended I think it is a very strange way to write it.
Your fix is correct, thanks Roel!
I really need to write a testsuite for this VIS emulation code.
|  |