Messages in this thread |  | | | Date | Sun, 8 Nov 2009 18:55:39 +1100 | | From | Stephen Rothwell <> | | Subject | Re: [patch 09/16] powerpc: Replace old style lock initializer |
Hi Ben,
On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > Looks reasonable. But iseries can be a bitch, so we do need to test it > on monday.
It should be safe as the spinlocks cannot be access until after the following ppc_md pointer initialisations are done (and all this happens before the secondary CPUs are started).
But, you are right that there is nothing like actually testing with iSeries. :-)
> > void __init hpte_init_iSeries(void) > > { > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(iSeries_hlocks); i++) > > + spin_lock_init(&iSeries_hlocks[i]); > > + > > ppc_md.hpte_invalidate = iSeries_hpte_invalidate; > > ppc_md.hpte_updatepp = iSeries_hpte_updatepp; > > ppc_md.hpte_updateboltedpp = iSeries_hpte_updateboltedpp;
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] |  |