lkml.org 
[lkml]   [2009]   [Nov]   [8]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 8 Nov 2009 18:01:57 +0100
FromPavel Machek <>
SubjectRe: [PATCH v2 resend] vfs: new O_NODE open flag
Hi!

> > The only really weird case Alan spotted is device nodes, where the
> > actual device registered to a major/minor pair changes over time,
> > possibly allowing a re-open to access a device it otherwise was not
> > meant to. BTW if the device number reuse happens really quickly, this
> > could even be a race for a plain open. Real solution might actually
> > be in udev: when deregistering a device, change mode bits to all-zero
> > before removing the device node.
>
> Devices nodes specifically were the case I was thinking of.
>
> Changing the mode bits to all-zero at the final unlink would be a lot
> more reliable and certain in the kernel.

Does it really close the race completely?

udev sets 660
open does permission checks
device disappears
chmod 000
new device appears
udev chmods 600
open returns new device

?
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-11-08 18:05    [W:0.230 / U:0.140 seconds]
©2003-2009 Jasper Spaans