Messages in this thread |  | | | From | André Goddard Rosa <> | | Date | Sun, 8 Nov 2009 14:59:08 -0200 | | Subject | Re: [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available |
On Sun, Nov 8, 2009 at 2:54 PM, Jan Engelhardt <jengelh@medozas.de> wrote: > > On Sunday 2009-11-08 17:38, James Bottomley wrote: > >>On Sat, 2009-11-07 at 14:23 -0200, André Goddard Rosa wrote: >>> + * skip_spaces - Removes leading whitespace from @s. >>> + * @s: The string to be stripped. >>> + * >>> + * Returns a pointer to the first non-whitespace character in @s. >>> + */ >>> +char *skip_spaces(const char *str) >> >>OK, so this now becomes a bad interface because it silently promotes >>const to non const ... > > strchr, etc. all do the same. Do you think they are bad too?
Yeap, I just based on those.
James, what would you suggest instead?
Thanks, André -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |